Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Yubikey OTP length before validating #3929

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Check Yubikey OTP length before validating #3929

merged 6 commits into from
Jun 3, 2024

Conversation

jona-samuel
Copy link
Contributor

closes #3746

@jona-samuel jona-samuel requested a review from plettich May 6, 2024 10:31
@jona-samuel
Copy link
Contributor Author

should we implement this for totp, hotp, SMS and email too?

@pep8speaks
Copy link

pep8speaks commented May 8, 2024 •
edited

Hello @jona-samuel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 440:56: E226 missing whitespace around arithmetic operator
Line 448:56: E226 missing whitespace around arithmetic operator

Comment last updated at 2024-05-28 14:35:48 UTC

plettich
plettich requested changes May 13, 2024
View reviewed changes
privacyidea/lib/decorators.py Outdated Show resolved Hide resolved
privacyidea/lib/tokens/emailtoken.py Outdated Show resolved Hide resolved
privacyidea/lib/tokens/hotptoken.py Outdated Show resolved Hide resolved
privacyidea/lib/tokens/smstoken.py Outdated Show resolved Hide resolved
privacyidea/lib/tokens/yubikeytoken.py Outdated Show resolved Hide resolved
@jona-samuel jona-samuel requested a review from plettich May 15, 2024 08:11
@plettich
Improve OTP value length check
dd2a59c 
- Improve log message and add tests for affected token types.
- Removed decorator for some types since the check will be performed by
  the called HOTP token class.
@plettich plettich merged commit 31fc394 into master Jun 3, 2024
18 checks passed
@plettich plettich deleted the 3902/Mark-privacyidea-token-in-the-qr-code branch June 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plettich plettich plettich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check Yubikey OTP length before validating
3 participants
@jona-samuel @pep8speaks @plettich