Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the @After hook example #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Apr 17, 2019

as it was before it was a bit confusing.

This example would have worked much better if the TODO left in code about passing the return value was implemented.
Then it could be something like:

image

as it was before it was a bit confusing
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          60       60           
  Lines         658      658           
  Branches       29       29           
=======================================
  Hits          600      600           
  Misses         56       56           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313c4b1...49384e9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant