Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: add pdp project examples #5854

Merged
merged 43 commits into from
May 15, 2024
Merged

init: add pdp project examples #5854

merged 43 commits into from
May 15, 2024

Conversation

ankur-arch
Copy link
Contributor

This PR adds Pulse and Accelerate project examples to the prisma-example repos.

@ankur-arch ankur-arch marked this pull request as draft April 12, 2024 16:14
@ankur-arch ankur-arch marked this pull request as ready for review April 22, 2024 15:27
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
prisma-data-platform/accelerate/nextjs/app/page.tsx Outdated Show resolved Hide resolved
prisma-data-platform/pulse/starter/global.d.ts Outdated Show resolved Hide resolved
prisma-data-platform/pulse/starter/index.ts Outdated Show resolved Hide resolved
ankur-arch and others added 3 commits April 23, 2024 11:32
prisma-data-platform/accelerate/nextjs/app/page.tsx Outdated Show resolved Hide resolved
prisma-data-platform/pulse/starter/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally this looks great, well done Ankur 👏 I've left a couple of comments that primarily relate to consistency of the READMEs and clarity of instructions.

prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/pulse/email-with-resend/README.md Outdated Show resolved Hide resolved
prisma-data-platform/accelerate/nextjs/README.md Outdated Show resolved Hide resolved
prisma-data-platform/accelerate/nextjs/README.md Outdated Show resolved Hide resolved
prisma-data-platform/accelerate/nextjs/README.md Outdated Show resolved Hide resolved
@jharrell jharrell self-assigned this Apr 25, 2024
@jharrell jharrell requested review from jharrell and nikolasburk and removed request for jharrell April 25, 2024 16:43
README.md Outdated Show resolved Hide resolved
Copy link
Member

@jharrell jharrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to see these changes, but not blocking.

accelerate/nextjs-starter/lib/db.ts Show resolved Hide resolved
accelerate/nextjs-starter/lib/db.ts Show resolved Hide resolved
accelerate/nextjs-starter/lib/utils/helpers.ts Outdated Show resolved Hide resolved
accelerate/nextjs-starter/lib/utils/query.ts Outdated Show resolved Hide resolved
accelerate/nextjs-starter/lib/utils/query.ts Outdated Show resolved Hide resolved
pulse/email-with-resend/script.ts Outdated Show resolved Hide resolved
pulse/email-with-resend/tsconfig.json Show resolved Hide resolved
pulse/starter/LICENSE Outdated Show resolved Hide resolved
pulse/starter/package.json Show resolved Hide resolved
pulse/starter/tsconfig.json Show resolved Hide resolved
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@jharrell jharrell merged commit 43ea69c into latest May 15, 2024
47 of 48 checks passed
@jharrell jharrell deleted the add-pdp-examples branch May 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants