Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline between markdown footnote definitions #16063

Merged
merged 3 commits into from May 25, 2024
Merged

Conversation

Atema
Copy link
Contributor

@Atema Atema commented Feb 8, 2024

Description

Ensures there are newlines between markdown footnote definitions, to comply with the standard set by Pandoc (https://pandoc.org/MANUAL.html#footnotes):

Each footnote should be separated from surrounding content (including other footnotes) by blank lines.

Resolves #8301

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Member

fisker commented May 10, 2024

Can you fix coflicts?

@kachkaev
Copy link
Member

@Atema can you please run Prettier for src/language-markdown/printer-markdown.js? CI is failing.

Copy link
Member

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atema! 🙌
@fisker WDYT?

@fisker
Copy link
Member

fisker commented May 25, 2024

I've approved two weeks ago, 😄

@fisker fisker merged commit 41f1dff into prettier:main May 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace is removed from between footnotes
3 participants