Expand Regex DoS check to include String#match and #match? coercion #1715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1714.
I added additional behavior to the existing
check_regex_dos.rb
file. I thought it seemed like the correct location because it is checking for ReDoS, though it's arguably a bit different because it's checking methods onString
rather than regex literals.I also am not sure whether I should also validate that the object being passed to
match
/match?
is a String; it seems like the expectation is that anyuser_input
will be a string, but I'm not confident about that.