Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start porting latest tgi #480

Merged
merged 32 commits into from
May 24, 2024
Merged

start porting latest tgi #480

merged 32 commits into from
May 24, 2024

Conversation

flozi00
Copy link
Collaborator

@flozi00 flozi00 commented May 20, 2024

What does this PR do?

@tgaddair its just for you, tracking progress now, please do not merge at the moment

This PR also introduces FP8 Linear and fp8 kv cache by vllm

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@flozi00 flozi00 linked an issue May 21, 2024 that may be closed by this pull request
@flozi00
Copy link
Collaborator Author

flozi00 commented May 22, 2024

Mistral + eetq tested and working

@flozi00
Copy link
Collaborator Author

flozi00 commented May 22, 2024

llama tested too

@flozi00 flozi00 marked this pull request as ready for review May 22, 2024 10:32
@flozi00 flozi00 linked an issue May 22, 2024 that may be closed by this pull request
@flozi00
Copy link
Collaborator Author

flozi00 commented May 22, 2024

Benchmark vs Main branch:
{"input_tokens_per_second": 14643, "output_tokens_per_second": 218} -- main
{"input_tokens_per_second": 15003, "output_tokens_per_second": 236} -- This PR

@flozi00
Copy link
Collaborator Author

flozi00 commented May 22, 2024

awq tested
Sharding tested

@flozi00 flozi00 requested a review from tgaddair May 22, 2024 10:56
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. Can land and then test it out further on main.

@tgaddair tgaddair merged commit a2ca687 into main May 24, 2024
3 checks passed
@tgaddair tgaddair deleted the synctgi branch May 24, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quantized KV Cache Fallback to Flash Attention v1 for pre-Ampere GPUs
2 participants