feat: adding husky to check for tests #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvar53
commented
May 27, 2022
|
@all-contributors please add @adandanielteamint for content |
|
I've put up a pull request to add @adandanielteamint! 🎉 |
rluvaton
reviewed
Jun 25, 2022
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| npm run build && npm test |
There was a problem hiding this comment.
I would run tests only on affected files using the --onlychanged flag to reduce the wait until the commit and leave the full tests run for the CI
| @@ -18,7 +18,8 @@ | |||
| "copy-templates": "rsync -av --exclude '*node_modules*' ./src/code-templates/ ./.dist/src/code-templates", | |||
| "build:watch": "tsc --watch", | |||
| "start:cli": "node ./.dist/bin/cli.js interactive", | |||
| "publish:build": "npm run build && npm publish ./.dist --access public" | |||
| "publish:build": "npm run build && npm publish ./.dist --access public", | |||
| "prepare": "husky install" | |||
There was a problem hiding this comment.
Then how do we fix this? Maybe activate only one flag --initialize-git --apply-git-hook?
@goldbergyoni @jalvar53 We can fix it but only running husky install if NODE_ENV is different than test
(Need to check if works well for Windows as well 😄)
Suggested change
| "prepare": "husky install" | |
| "prepare": "test \"$NODE_ENV\" == \"test\" || husky install" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Husky can't be added to the generated code since it requires a .git folder (A Git repository created inside) to be able to hook to it.