Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum viable prototype of "daily challenge" feature #28195

Merged
merged 10 commits into from
May 23, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented May 17, 2024

2024-05-17.11-39-05.mp4

This would conclude what I would consider to be the first minimal releasable increment of this feature.

The daily challenge room is not filtered out of playlists yet despite prior discussion because things are set up such that exiting out of the playlist puts you into the lobby, so it kinda makes sense to me to keep it there for now (and hiding it is a bit annoying given current setup, so if we end up redoing the screen to be a completely separate thing then it'd be wasted effort).

The diffsize is pushing it, but most of the diff is visuals and tests, so I'm hoping it won't be an issue. Am willing to split stuff out if required, just don't wanna do it without causing more ceremony than necessary (see: dependency list).

@bdach bdach self-assigned this May 17, 2024
@peppy peppy self-requested a review May 21, 2024 04:46
@peppy
Copy link
Sponsor Member

peppy commented May 23, 2024

@bdach I'm not sure which change specifically caused this (likely the state handling of ButtonSystemState or changes to initial button width) but the animation no longer plays the first time each level of menu is shown:

master:

2024-05-23.17.22.03.mp4

this pr:

2024-05-23.17.21.06.mp4

I think it might be faster if you check on this since you're more familiar with your changes.

@bdach
Copy link
Collaborator Author

bdach commented May 23, 2024

I'm not sure which change specifically caused this (likely the state handling of ButtonSystemState or changes to initial button width) but the animation no longer plays the first time each level of menu is shown:

bfa23ec should do it I reckon. Code quality is... dubious in those parts 😅

@peppy peppy merged commit f78c17c into ppy:master May 23, 2024
12 of 17 checks passed
@bdach bdach deleted the daily-challenge-mvp branch May 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants