Minimum viable prototype of "daily challenge" feature #28195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-05-17.11-39-05.mp4
This would conclude what I would consider to be the first minimal releasable increment of this feature.
The daily challenge room is not filtered out of playlists yet despite prior discussion because things are set up such that exiting out of the playlist puts you into the lobby, so it kinda makes sense to me to keep it there for now (and hiding it is a bit annoying given current setup, so if we end up redoing the screen to be a completely separate thing then it'd be wasted effort).
The diffsize is pushing it, but most of the diff is visuals and tests, so I'm hoping it won't be an issue. Am willing to split stuff out if required, just don't wanna do it without causing more ceremony than necessary (see: dependency list).