-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system clipboard for hitobjects in the editor #27707
Open
minetoblend
wants to merge
11
commits into
ppy:master
Choose a base branch
from
minetoblend:feature/hitobjects-system-clipboard
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e71ccc5
Use system clipboard for storing hitobjects in editor
minetoblend bd3984a
Use a constant for the hitobject clipboard value
minetoblend 9e54f70
Add extra check after parsing clipboard content
minetoblend 6c9d9d6
Remove empty function
minetoblend 1a13f3e
Use ClipboardData instead of ClipboardEntry
minetoblend da35927
Change function call to match changes in osu-framework
db06841
Use correct mime type for hitobject clipboard content
d1f75b8
Gracefully handle unparseable clipboard content
2f8bef8
Add test cases for editor clipboard
9adb9dd
Add assertions for clipboard content to `TestSceneEditorClipboard`
b2d1771
Make sure clipboard is cleared before each test
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a valid mime format, should probably be something like
application/x-osu-hitobjects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.rfc-editor.org/rfc/rfc6838.html#section-3.4
https://www.rfc-editor.org/rfc/rfc6838.html#section-4.2.8
So it should be
application/x.osu.hitobjects+json
.Please note that web custom formats are prefixed with
web
in the javascript API (animage/png
andweb image/png
can be different things). I'm still thinking about how this should be handled.