Fix GameHost.Collect()
being called twice on android
#6272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (to have identical behaviour):
onTrimMemory()
instead ofonLowMemory()
on Android libsdl-org/SDL#9654SDL sends us a
SDL_EVENT_LOW_MEMORY
when Android'sonLowMemory()
handler fires. o!f handles this event and callsGameHost.Collect()
. We also have our own handling inonTrimMemory()
. Depending on how android handles those two functions, we may collect memory twice.I think it makes more sense to just have
SDL_EVENT_LOW_MEMORY
handling, and not have custom logic just for android.This PR was originally meant to pick out the useful parts from https://github.com/ppy/osu-framework/pull/6269/files#r1584189904, but I've since realised SDL already sends us a low memory event that we handle.