Update CRD to apiextensions/v1 #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the Kubernetes CRD and associated tooling to conform to apiextensions/v1. * Changes the apiVersion, and shuffles around some fields based on the new structure of the v1 API * Adds a basic package.json so that you can run the updateSchema.js script * Adds some addition field stripping in the updateSchema.js script that removes fields in accordance with the new requirement that CRDs be 'structural'. * Removes the nullable property from the start nodeAction. Structural CRDs cannot have nullable fields. Signed-off-by: Nikolas Skoufis <[email protected]>
Aergonus
reviewed
Oct 24, 2021
| @@ -19,8 +19,8 @@ function removeKey(obj, keyNames) { | |||
| } | |||
|
|
|||
| function updateCRDFile(crdFilename, jsonSchemaFilename) { | |||
| let jsonSchema = yaml.safeLoad(fs.readFileSync(jsonSchemaFilename, 'utf8')); | |||
| let crd = yaml.safeLoad(fs.readFileSync(crdFilename, 'utf8')); | |||
| let jsonSchema = yaml.load(fs.readFileSync(jsonSchemaFilename, 'utf8')); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Kubernetes CRD and associated tooling to conform to
apiextensions/v1. Closes #344
new structure of the v1 API
script
removes fields in accordance with the new requirement that CRDs be
'structural'.
CRDs cannot have nullable fields.
Outstanding questions:
CONTRIBUTING.MDfile?