Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire component's events #390

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

AbrahemAlhofe
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • [X ] Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [X ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • [ X] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

    Promised fires 'resolved' event when the promise is resolved,
    fires 'rejected' event when the promise is rejected and
    fires 'pending' event when pending delay time is elapsed.

close posva#311
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #390 (7b06d43) into v2 (dd5db7f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                v2      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           58        67    +9     
  Branches        20        27    +7     
=========================================
+ Hits            58        67    +9     
Impacted Files Coverage Δ
src/Promised.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5db7f...7b06d43. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant