Depend on require.js to make it usable with other UMD HTMLDependency()s #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
4 times, most recently
from
f913db1
to
cb58cb0
Compare
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
3 times, most recently
from
8fff1f2
to
9b10664
Compare
cpsievert
commented
May 13, 2022
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
9b10664
to
77cd8bb
Compare
cpsievert
commented
May 16, 2022
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
26ea404
to
0f539a9
Compare
… a monkey-patched define to allow for an anonymous define() escape hatch
…lready define()s it
…or binding after registration
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
0f539a9
to
449e787
Compare
…e window (and define them just after loading requirejs)
… shims with require.min.js
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
71cac27
to
8e97e4f
Compare
This reverts commit 8e97e4f.
cpsievert
commented
May 20, 2022
cpsievert
commented
May 20, 2022
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
18c6ad2
to
02855f8
Compare
cpsievert
force-pushed
the
requirejs-jquery-ui
branch
from
c27f363
to
3d1bc36
Compare
cpsievert
changed the title
jcheng5
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120
(Also updates Bootstrap to the current one in
{bslib})