Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdcard structure refactor - sdcard part #1968

Open
wants to merge 36 commits into
base: next
Choose a base branch
from

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Mar 10, 2024

for easier review, i separated firmware change part and sdcard change part. This is sdcard change part
please don't merge as i need to merge myself.
test build(put world map yourself): https://github.com/zxkmm/mayhem-firmware/releases/tag/test_release

@zxkmm zxkmm changed the title sdcard refactor - sdcard part sdcard structure refactor - sdcard part Mar 10, 2024
@zxkmm zxkmm marked this pull request as ready for review March 10, 2024 13:19
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an empty USR file with a description stating something like HERE WILL APPEAR YOUR DATA or something equal

@zxkmm
Copy link
Contributor Author

zxkmm commented Mar 12, 2024

Sure, but isn’t ensure_dir enough? I can add empty folders and git keep it tho.

@zxkmm
Copy link
Contributor Author

zxkmm commented Mar 12, 2024

Please also add an empty USR file with a description stating something like HERE WILL APPEAR YOUR DATA or something equal

Done

@gullradriel
Copy link
Member

Once changed with all the suggestions, it will look clear and professional.
Let me go and check the other one now ^^

@zxkmm zxkmm requested a review from jLynx April 2, 2024 23:03
sdcard/UPDATE_GUIDE.TXT Outdated Show resolved Hide resolved
sdcard/SYS/CAPTURES/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
sdcard/SYS/FREQMAN/THIS_IS_DEMO_FOLDER Outdated Show resolved Hide resolved
sdcard/SYS/PLAYLIST/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
sdcard/SYS/REMOTES/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
sdcard/SYS/SPLASH/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
sdcard/SYS/SSTV/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
sdcard/SYS/WAV/THIS_IS_DEMO_FOLDER.TXT Outdated Show resolved Hide resolved
@zxkmm
Copy link
Contributor Author

zxkmm commented Apr 3, 2024

all requests fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants