Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-8772 | Add filter to opencost integration #749

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lordsarcastic
Copy link
Contributor

Description

What:

  • Added filter params to Opencost cloudcost and Kubecost cloud and kubesystem kind.
  • Implemented separate config for v1 and v2 selectors for Kubecost cloud and kubesystem kind

Why:

  • Opencost and Kubecost added the filter feature which is a much more powerful aggregation parameter as opposed to the existing fields, adding this field allows users to be much more flexible with what data they ingest into Port
  • The Kubecost integration, while currently on v1 as set:
KUBECOST_API_VERSION_1 = "v1"

Uses the same selector to handle filters for both kubesystem and cloud kinds which should be separate. In addition, the params accepted by v1 is not the same as that on v2; this applies to both kinds.

How:
To address these needs, different selectors are defined for each kind and for each version and can be used when needed

Type of change

Please leave one option from the following and delete the rest:

  • New feature (non-breaking change which adds functionality)
  • Non-breaking change (fix of existing functionality that will not change current behavior)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@lordsarcastic lordsarcastic changed the title PORT-8772 PORT-8772 | Add filter to opencost integration Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant