Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT 8673 aws integration add describe resources to config #714

Merged

Conversation

shalev007
Copy link
Contributor

  • feat: add describe_resources config
  • feat: add describe each to cloudcontrol
  • fix: remove unnecessary describe_resources in custom kinds

Description

What - Add describe_resources propery to AWS mapping.
Why - Most of CloudControl resources return without most of their properties like "Tags" propery is missing.
How - Add option on the config to describe each resource so all of their resources will return.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

https://docs.aws.amazon.com/cloudcontrolapi/latest/userguide/resource-operations-list.html

@shalev007 shalev007 force-pushed the PORT-8673-aws-integration-add-describe-resources-to-config branch from 796d756 to 71425ae Compare June 16, 2024 08:15
@github-actions github-actions bot added size/L and removed size/S labels Jun 16, 2024
@shalev007 shalev007 force-pushed the PORT-8673-aws-integration-add-describe-resources-to-config branch from 1e31ebf to 98673e7 Compare June 16, 2024 08:22
@shalev007 shalev007 force-pushed the PORT-8673-aws-integration-add-describe-resources-to-config branch from 685cb02 to 14161d8 Compare June 16, 2024 09:20
@shalev007 shalev007 merged commit 88d0ef6 into main Jun 16, 2024
11 of 14 checks passed
@shalev007 shalev007 deleted the PORT-8673-aws-integration-add-describe-resources-to-config branch June 16, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants