[Framework] Port 8572 ocean startup when saas #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up-when-Saas # Conflicts: # CHANGELOG.md # port_ocean/core/defaults/initialize.py # pyproject.toml
…up-when-Saas # Conflicts: # CHANGELOG.md # pyproject.toml
…up-when-Saas # Conflicts: # CHANGELOG.md
port_ocean/core/utils.py
Outdated
Comment on lines
39
to
40
| raise Exception( | ||
| f"Can't run {current_runtime} integration in {requested_runtime} runtime" |
There was a problem hiding this comment.
Please use custom exception that inherit ocean exceptions
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "port-ocean" | |||
| version = "0.7.1" | |||
| version = "0.7.2" | |||
There was a problem hiding this comment.
Its a new feature therefore it should be a new minor
…up-when-Saas # Conflicts: # CHANGELOG.md
yairsimantov20
approved these changes
Jun 19, 2024
port_ocean/core/utils.py
Outdated
| current_integration = await port_client.get_current_integration(should_raise=False) | ||
| current_runtime = current_integration.get("installationType", "OnPrem") | ||
| if current_integration and current_runtime != requested_runtime: | ||
| raise OceanAbortException( |
There was a problem hiding this comment.
ocean abort exception are for resyncs
can you create a new dedicated exception derived from BaseOceanException?
Comment on lines
+33
to
+35
| async def validate_integration_runtime( | ||
| port_client: PortClient, requested_runtime: Runtime | ||
| ) -> None: |
There was a problem hiding this comment.
maybe add a debug log
CHANGELOG.md
Outdated
| @@ -7,6 +7,13 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| <!-- towncrier release notes start --> | |||
|
|
|||
| ## 0.9.0 (2024-06-18) | |||
port_ocean/core/utils.py
Outdated
| current_runtime = current_integration.get("installationType", "OnPrem") | ||
| if current_integration and current_runtime != requested_runtime: | ||
| raise OceanAbortException( | ||
| f"Can't run {requested_runtime} integration in {current_runtime} runtime" |
There was a problem hiding this comment.
Be more precise and verbose
…up-when-Saas # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - handle startup when running as saas
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.