Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][Datadog] Revise default blueprints #692

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[Integration][Datadog] Revise default blueprints #692

wants to merge 13 commits into from

Conversation

phalbert
Copy link
Contributor

@phalbert phalbert commented Jun 4, 2024 •
edited
Loading

Description

What -
Why -
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@phalbert phalbert self-assigned this Jun 4, 2024
@phalbert phalbert changed the title [Integration][Datadog] Revise default blueprint [Integration][Datadog] Revise default blueprints Jun 4, 2024
@github-actions github-actions bot added the size/M label Jun 4, 2024
matan84
matan84 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tankilevitch
Tankilevitch requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version bump and changelog

@phalbert
Copy link
Contributor Author

missing version bump and changelog

I have resolved this now

Tankilevitch
Tankilevitch requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't bump the pyproject.toml

matan84
matan84 requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a version bump in the pyproject.toml file

integrations/datadog/poetry.lock Outdated Show resolved Hide resolved
integrations/datadog/CHANGELOG.md Outdated Show resolved Hide resolved
integrations/datadog/.port/resources/blueprints.json Outdated Show resolved Hide resolved
integrations/datadog/.port/resources/blueprints.json Outdated Show resolved Hide resolved
matan84
matan84 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matan84 matan84 matan84 approved these changes

@Tankilevitch Tankilevitch Awaiting requested review from Tankilevitch

Requested changes must be addressed to merge this pull request.

Assignees

@phalbert phalbert

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phalbert @matan84 @Tankilevitch @yairsimantov20