Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directory change in warp/iterm2 environments #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atian25
Copy link
Collaborator

@atian25 atian25 commented May 14, 2024

Related to #64

Implements support for automatically switching to the corresponding directory in warp/iterm2 environments after adding a project, and updates the version number.

  • Adds a new function generateWarpScript in lib/utils.js to generate a script for changing directories in warp/iterm2 environments.
  • Modifies generateAppleScript in lib/utils.js to include support for warp/iterm2 environments by adding a warpCommand script and updating the return statement to execute the appropriate script based on the current terminal application.
  • Updates lib/command/add.js and lib/command/find.js to support changing directories in warp/iterm2 environments by utilizing the updated generateAppleScript function. Additionally, introduces a check for the TERM_PROGRAM environment variable to determine if the terminal is Warp and uses the generateWarpScript function accordingly.
  • Increments the version number in package.json to 2.2.0 to reflect the new feature addition.

For more details, open the Copilot Workspace session.

Summary by CodeRabbit

  • New Features

    • Added support for the 'Warp' environment in directory-changing commands.
  • Improvements

    • Enhanced error messages to reflect support for the 'Warp' environment.
  • Version Update

    • Updated project version from 2.1.0 to 2.2.0.

Copy link

coderabbitai bot commented May 14, 2024

Walkthrough

The recent update enhances the projj project by adding support for the 'Warp' environment in the AddCommand and FindCommand classes, allowing for seamless directory changes. Additionally, a new utility function generateWarpScript was introduced to facilitate this functionality. The version has been updated to 2.2.0, reflecting these improvements.

Changes

Files Change Summaries
lib/command/add.js Added support for changing directories in 'Warp' environment and updated error message.
lib/command/find.js Updated logic to support changing directories in 'Warp' environment.
lib/utils.js Introduced generateWarpScript function for Warp-specific directory change script generation.
package.json Updated project version from 2.1.0 to 2.2.0.

In code we trust, through Warp we steer,
New paths unfold, no need to fear.
With scripts anew, our journey's clear,
Version 2.2.0, let's give a cheer!

~ 🐰 CodeRabbit 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b2ef85c and ec492af.
Files selected for processing (4)
  • lib/command/add.js (1 hunks)
  • lib/command/find.js (1 hunks)
  • lib/utils.js (1 hunks)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional comments not posted (5)
lib/utils.js (3)

14-18: Add Warp terminal support to generateAppleScript.

The added script for the Warp terminal is consistent with the existing scripts for Terminal and iTerm. The logic appears correct.


24-24: Update the return statement to include Warp terminal support.

The return statement correctly includes the Warp terminal script, ensuring the appropriate script is executed based on the current terminal application.


27-32: Add new function generateWarpScript.

The function correctly generates a script for the Warp terminal, consistent with the existing script generation functions.

lib/command/add.js (1)

35-39: Add support for Warp terminal in AddCommand.

The added logic correctly checks for the Warp terminal and generates the appropriate script. The code is consistent with the existing logic for the Darwin platform.

lib/command/find.js (1)

39-43: Add support for Warp terminal in FindCommand.

The added logic correctly checks for the Warp terminal and generates the appropriate script. The code is consistent with the existing logic for the Darwin platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant