[DO NOT MERGE YET] State & orbit array API (iterative implementation) #1492
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very high-level comments from our weekly meeting:
- Let's avoid allocating memory ourselves and accept an
out=
parameter instead - @s-m-e will work on the tests before calling for review
- Let's break this down into pieces: first, the low hanging fruit (pytest-xdist, decorators going away, etc)
- Then, we should open another PR for the
State
signature change (the epoch)
- Then, we should open another PR for the
While working on gh-1521, I realized it would have been cool to have a In summary: @s-m-e advocates for having it in the a. have this information in a higher-level object, potentially introducing small complications in the implementation of some algorithms, or I'll try to devote some thinking to this during SciPy. |
More arguments for keeping the epochs outside of StateArrays:
|
This PR aims at providing a full
OrbitArray
API and corresponding tests while relying on a slow iterative implementation based onOrbit
first. This should allow the implementation of proper tests before cleanup and refactoring of other package internals begins.