Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

animated_plots #1131

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

dark00infinity
Copy link

@dark00infinity dark00infinity commented Mar 21, 2021

Addresses issue #299

  • single orbit animation
  • orbital speed change
  • multi orbit animation
  • 3D orbit animation
  • code cleaning

@dark00infinity dark00infinity temporarily deployed to validation-env March 21, 2021 02:22 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 21, 2021 02:27 Inactive
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1131 (74d417e) into main (48bf2c6) will increase coverage by 0.05%.
The diff coverage is 93.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   89.98%   90.04%   +0.05%     
==========================================
  Files          75       76       +1     
  Lines        4035     4109      +74     
  Branches      362      370       +8     
==========================================
+ Hits         3631     3700      +69     
- Misses        314      315       +1     
- Partials       90       94       +4     
Impacted Files Coverage Δ
src/poliastro/twobody/orbit.py 79.64% <ø> (ø)
src/poliastro/plotting/animate.py 91.30% <91.30%> (ø)
src/poliastro/plotting/_base.py 89.08% <96.15%> (+1.24%) ⬆️
src/poliastro/plotting/__init__.py 100.00% <100.00%> (ø)
src/poliastro/plotting/static.py 92.00% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bf2c6...74d417e. Read the comment docs.

@dark00infinity dark00infinity temporarily deployed to validation-env March 21, 2021 04:39 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 21, 2021 06:17 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 21, 2021 06:20 Inactive
@dark00infinity dark00infinity marked this pull request as ready for review March 21, 2021 08:32
@dark00infinity dark00infinity marked this pull request as draft March 21, 2021 08:44
@dark00infinity dark00infinity marked this pull request as ready for review March 21, 2021 09:11
@dark00infinity dark00infinity changed the title animated_plots [WIP} animated_plots Mar 21, 2021
@dark00infinity dark00infinity changed the title [WIP} animated_plots [WIP] animated_plots Mar 21, 2021
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 09:00 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 09:04 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 09:15 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 09:22 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 12:37 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 12:41 Inactive
@DhruvSondhi
Copy link
Contributor

Hello @dark00infinity, If this PR is a Work in Progress effort ... It is better to convert it to a Draft PR ... You can always mark it Ready for Review whenever you feel this is ready :)

@dark00infinity dark00infinity marked this pull request as draft March 22, 2021 13:03
@dark00infinity
Copy link
Author

Hello @dark00infinity, If this PR is a Work in Progress effort ... It is better to convert it to a Draft PR ... You can always mark it Ready for Review whenever you feel this is ready :)

ok @DhruvSondhi

@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 13:31 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 15:24 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 16:06 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 22, 2021 16:26 Inactive
@dark00infinity dark00infinity temporarily deployed to validation-env March 23, 2021 02:12 Inactive
@dark00infinity dark00infinity marked this pull request as ready for review March 23, 2021 02:51
@dark00infinity dark00infinity changed the title [WIP] animated_plots animated_plots Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants