UI: Hierarchical taxonomies as checkboxes in attachment modal #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to media library
JoryHogeveen
added
Type: Enhancement
sc0ttkclark
added
the
Status: In Progress
JoryHogeveen
added
the
Status: Need Dev Feedback
|
This looks cool, I'm open to it being included. What's left? |
|
Hi Scott, See todo and comment :) |
JoryHogeveen
commented
Dec 12, 2016
| * Validate for an array | ||
| * Otherwise we didn't change this functionality since this is a string by default in WP core | ||
| */ | ||
| if ( is_taxonomy_hierarchical( $tax ) && is_array( $terms ) ) { |
There was a problem hiding this comment.
Maybe also verify that this is a Pods field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3765
TODO:
@sc0ttkclark Currently the PR is not ready, it's dependent on wether the attachment post type has any fields because otherwise nothing gets loaded. Please let me know if you think this should be a Pods feature. If yes I'll continue with this in Pods.