Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test on Node.js 22 #8010

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: test on Node.js 22 #8010

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c26a06
ci: test on Node.js 22
zkochan Apr 24, 2024
2f69364
ci: update npm
zkochan Apr 24, 2024
616365a
ci: update npm
zkochan Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
node:
- '18.12'
- '20'
- '21'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to test against v21?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v21 is not an lts version. When 22 is out, v21 is basically deprecated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you can see, we don't test v19 as well.

- '22'
platform:
- ubuntu-latest
- windows-latest
Expand All @@ -43,8 +43,8 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: 'pnpm'
- name: Install npm@7
run: npm add --global npm@7
- name: Install npm@10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm v10 appears to require a minimum version of Node v20.

Do we want to do a matrix of node-version and npc-version to accommodate for this?

run: npm add --global npm@10
- name: pnpm install
run: pnpm install
- name: Audit
Expand All @@ -70,6 +70,6 @@ jobs:
- name: run tests (branch)
timeout-minutes: 60
if: github.ref != 'refs/heads/main'
run: pnpm run test-branch
run: pnpm run test-main
env:
PNPM_WORKERS: 3