Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to async/await - leftover src files #5837

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor codebase to async/await - leftover src files #5837

wants to merge 4 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #5147

@milanholemans
Copy link
Contributor

Thank you @MathijsVerbeeck, we'll try to review it ASAP!

@martinlingstuyl martinlingstuyl self-assigned this Feb 24, 2024
@martinlingstuyl
Copy link
Contributor

Hi @MathijsVerbeeck, could you rebase this PR on main and fix the merge conflicts? The multi-account feature that is released has caused this. 😅

@MathijsVerbeeck
Copy link
Contributor Author

Hi @MathijsVerbeeck, could you rebase this PR on main and fix the merge conflicts? The multi-account feature that is released has caused this. 😅

Should be done!

martinlingstuyl
martinlingstuyl reviewed Mar 1, 2024
View reviewed changes
src/request.spec.ts Outdated Show resolved Hide resolved
martinlingstuyl
martinlingstuyl reviewed Mar 1, 2024
View reviewed changes
src/request.ts Outdated Show resolved Hide resolved
martinlingstuyl
martinlingstuyl requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, cleans up nicely!!

@martinlingstuyl martinlingstuyl marked this pull request as draft March 1, 2024 21:45
@martinlingstuyl
Copy link
Contributor

Hi @MathijsVerbeeck, you may have forgotten about this PR? Maybe you could find some time to fix it, so we can get it in? Let me know if you need any help!

@MathijsVerbeeck
Copy link
Contributor Author

@martinlingstuyl definitely not, I have asked a question but it seems that you didn't notice that question 😁

@martinlingstuyl
Copy link
Contributor

@martinlingstuyl definitely not, I have asked a question but it seems that you didn't notice that question 😁

Ah, my bad :-)
I'll check it out...

@MathijsVerbeeck
Copy link
Contributor Author

@martinlingstuyl I think that we are there. Could you please have another look?

@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review May 3, 2024 20:40
@MathijsVerbeeck MathijsVerbeeck mentioned this pull request May 3, 2024
Open
martinlingstuyl
martinlingstuyl requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MathijsVerbeeck, looking at the code I think we unfortunately need to revisit our timeout decision... check out my comments on that...

src/request.ts Outdated Show resolved Hide resolved
src/request.ts Show resolved Hide resolved
src/request.ts Show resolved Hide resolved
src/request.ts Outdated Show resolved Hide resolved
src/request.spec.ts Outdated Show resolved Hide resolved
src/request.spec.ts Outdated Show resolved Hide resolved
src/request.spec.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft May 12, 2024 21:15
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review May 17, 2024 14:45
martinlingstuyl
martinlingstuyl requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there @MathijsVerbeeck. Got a few last remarks

src/request.spec.ts Show resolved Hide resolved
src/request.ts Outdated Show resolved Hide resolved
src/request.ts Outdated Show resolved Hide resolved
src/request.spec.ts Show resolved Hide resolved
src/request.spec.ts Show resolved Hide resolved
src/request.spec.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft May 21, 2024 20:25
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review May 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl requested changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor codebase to async/await - leftover src files
3 participants
@MathijsVerbeeck @milanholemans @martinlingstuyl