New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5 #2138
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Size Change: -46.6 kB (-88.3%) 🏆 Total Size: 6.17 kB
|
Maybe consider changing React Snowpack to React Vite on CodeSandbox? |
I think you can just add it, if you are talking about |
I'll see if I've got some time in the nearest future :) |
I'm a noob learning things and asking around. I noticed many libraries dropping default exports. may I ask why? |
@TheMikeyRoss Can you open a new discussion? https://github.com/pmndrs/zustand/discussions/new |
@dai-shi, I see the checklist in the PR description, could I help tackle some of the bullet points? Thanks |
@charkour I was wondering when we should start this, but if you are interested please go ahead. Note that I may have some hidden requirements which isn't described well in the bullet points, so bear with me. (I think I should work on the TS one on my own.) We do something like this pmndrs/valtio#810, so please open PRs for each point against |
Sounds great! I can start on dropping the default exports. No worries on the hidden requirements, I'm happy to help and let you take over if you disagree with one of my changes. |
* fix: drop default exports for v5 * chore: remove default from cjs build * refactor: export shallow in v5 * fix: remove `addModuleExport` option for cjs.
@bluejoyq that's for middlewares |
that's for typescript for middleware. it's redundant for JS. can't be helped. |
* chore: remove devtools extension warning * docs: add devtools link to readme * chore: remove unused test * chrome: remove unused tests * chore: remove unused test * Revert "chore: remove unused test" This reverts commit 0fa2a75. * update test name
"./*"
in package.json exports and change Node.js requirement [v5] use "./*" in package.json exports and change Node.js requirement #2272getServerState
#2300