fix(USDZExporter): alpha issues in diffuse map #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
CodyJasonBennett
changed the title
|
🎉 This PR is included in version 2.30.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When applying a texture with a transparent background, the USDZ exporter doesn't export the transparency of the texture. In this PR it will fix it.
What
I changed the shader of the USDZ exporter to include the
opacityasalphaandopacityThreshold. The applied changes are based of the Pull request in THREE,js USDZExporter: Support opacity materials. It looks like this change later was removed from the source code again. I reimplemented it in this code base with an additional step to always include anopacityThresholdof0.01when the material is transparent since it will show a white blur if not.