[java] Make naming conventions rule skip unnamed variables #5004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I think the best solution here is not to allow
_
through the regexes as suggested in #4954 but rather to always ignore these variables. That's because I don't think the rule should ever be used to disallow unnamed variables. We would otherwise be restricting a useful language feature, and anyone changing the convention would need to explicitly takes care of special casing this identifier.Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)