migration of @nivo/core
to typescript and (partial) upgrade to React 18
#2046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1219, #884 (partially)
Summary
@nivo/core
to typescript@nivo/recompose
frompackages
todeprecated
.@nivo/tooltip
into@nivo/core
. They had mutual peer dependencies, and I couldn't get them to build separately.line
andwaffle
, alsogeo
andparallel-coordinates
). These packages are non-functioning in this branch.@nivo/core
and pass build/lint/testpackages/core/migration.md
Checks
make init
(building all packages from scratch)make packages-lint
make packages-test
(but non-typescript tests are disabled)make storybook
and produces working charts (but non-typescript charts are disabled)Open issues / questions
@plouc, I set this as 'draft' to signal that it shouldn't be merged at this stage. But I hope some of it is useful. With your comments, we can extend this to address the issues, or move some material into smaller updates. Thanks!