Add support for xref/yref paper for shapes with layer "between" #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it fell back to "below" for paper refs
archmoj
reviewed
Apr 30, 2024
archmoj
reviewed
Apr 30, 2024
there are now always 2 cartesian subplots where there was 1 before (one for background and one for foreground)
…r gridlayer Gridlayer is now in cartesianlayer-below, so it is below xaxislayer-above anyways.
|
@archmoj I finally fixed all failing tests except for baselines. Could you have a look again? :) |
archmoj
reviewed
May 8, 2024
archmoj
reviewed
May 8, 2024
archmoj
reviewed
May 8, 2024
archmoj
reviewed
May 8, 2024
…efined, plotgroup]
…d and countSublotsForeground
|
Again, remaining failing tests are unrelated baseline images (I think). |
|
@archmoj Please let me know if there is anything else I should look into before the PR can be approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a shape with layer "between" and xref/yref "paper" fell back to layer = "below".
To support paper refs, I split up the
cartesianLayerinto acartesianLayerBelow(where plot background and gridlines are drawn) andcartesianLayerAbove(where the rest is drawn). Between the two is a newlayerBetween.Disclaimer
I am required to add that…the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.