Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features #6909

Open
wants to merge 78 commits into
base: master
Choose a base branch
from
Open

Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features #6909

wants to merge 78 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 28, 2024 •
edited

@plotly/plotly_js

TODOs:

  • Fix regl_codegen
  • Test the bundle on the plotly.py side
  • Test custom bundles
  • Test new bundle in amdefine
  • Test new bundle in requirejs
  • Test new bundle in kaleido
  • Test new bundle in orca

alexcjohnson and others added 30 commits February 28, 2024 11:00
@alexcjohnson @archmoj
esbuild first cut
24876d8 
seems to work for everything except regl traces
@alexcjohnson @archmoj
put output name back to plotly.js
8d6d9ee
@archmoj
update package-lock diff
fd7e445
@archmoj
uninstall webpack
59af538
@archmoj
uninstall webpack-cli
9481fe5
@archmoj
uninstall node-polyfill-webpack-plugin
b70ad83
@archmoj
uninstall karma-webpack
ab7abd5
@archmoj
drop webpack from devtools/test_dashboard/server.mjs
63d3de8
@archmoj
remove webpack.config.js
55c03d8
@archmoj
install buffer
2b8d93a
@archmoj
install assert
cf5633e
@archmoj
rename devtools/regl_codegen/server from js to mjs
ca525fd
@archmoj
remove unused purgeGeneratedCode function
390b0f1
@archmoj
replace esbuild with webpack in devtools/regl_codegen/server
2a04743
@archmoj
rename tasks/bundle.js to tasks/bundle.mjs
0d6fd10
@archmoj
es6 imports in tasks/bundle.mjs
abc4532
@archmoj
bundle_wrapper.js > bundle_wrapper.mjs
687276a
@archmoj
rename cibundle.js & partial_bundle.js to .mjs
5701b7e
@archmoj
es6 import _bundle function
34f564e
@archmoj
replace webpack with esbuild in bundle_wrapper
80f0547
@archmoj
use esbuild to make bundles
ea7b866
@archmoj
rewrite custom_bundle and extra_bundles in es6
ad00767
@archmoj
js > mjs
c2c21d9
@archmoj
adjust export in partial_bundle.mjs
1ebbfad
@archmoj
do not provide sourcemap for now
a6d1437
@archmoj
fix bundle_wrapper
bf75f64
@archmoj
skip no-new-func test for now
1ccaec5
@archmoj
delete node12 tests
867ba0d
@archmoj
set minimum node16 in package.json
e2b52c6
@archmoj
update package-lock for node 16 minimum
d529e2a
@archmoj archmoj mentioned this pull request Feb 28, 2024
Draft
@archmoj archmoj changed the title Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@archmoj archmoj

Labels
status: reviewable type: maintenance type: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson