Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react to config changes #6395

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

react to config changes #6395

wants to merge 3 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 14, 2022

Fixes #6394.

@plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Nice! Maybe then just a test like this one but for cartesian?

it('can put polar plots into staticPlot mode', function(done) {

@archmoj
Copy link
Contributor Author

archmoj commented Dec 21, 2022

@alexcjohnson I don't recall what noCIdep was about. ¯\_(ツ)_/¯
After the changes proposed in this PR, it looks like we need to adjust the cartesian test right above the line you mentioned.

@alexcjohnson
Copy link
Collaborator

@noCIdep came in here: 623146f91c

    // Although not recommended, some tests "depend" on other
    // tests to pass (e.g. the Plotly.react tests check that
    // all available traces and transforms are tested). Tag these
    // with @noCIdep, so that
    // - $ npm run test-jasmine -- tags=noCI,noCIdep
    // can pass.

So looks like on CI it's ignored, but it marks tests that need to run so the noCI tests succeed. Quite possibly obsolete by now, you could try running just npm run test-jasmine -- tags=noCI and see if it works?

And good call, I somehow hadn't noticed the cartesian test right above that 😅 But that test was already passing, right? So what can we add to that test that would have broken before this change but now works correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the config of a plot
2 participants