New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(geomean): add geomean function #6223
base: master
Are you sure you want to change the base?
Conversation
e2c41a9
to
cf2dc9a
Compare
@alexcjohnson should this be supported in other places like histfunc etc? |
@nicolaskruchten is that referring to just geomean or the entire categoryorder attribute? |
geomean: all the other aggregation functions you can sort by (sum, mean, median) are also supported in a few other places like |
I'd be down to tackle that in another PR if you can list where else to add the geomean statistic. |
Wondering geomean may not be the best naming as it could be point to our |
On another note, we are wondering why the automatic |
yea, edit: a quick goog/bing search shows the wikipedia article of Geometric mean with a search query of |
I was gonna ask you guys the same thing lol. |
I can try rebasing these commits on master and force pushing to see if that triggers the CI? |
Force pushing is discouraged on open pull requests as it could confuse reviewers. |
@antoinerg any idea how we could trigger CI runs on this pull? |
I see your point, though I think in context it's pretty clear. Looking around I see Harmonic mean commonly refers to the inverse of the mean of inverses (see eg npm and python stdlib) so let's stay away from that. But given that we all agree
Yes, that would be nice. I only see two more places we could add this, and one of them (the aggregate transform) is deprecated so I'm happy to ignore that. So Two frustrating things though: (1) we weren't consistent about the naming - for (2) The implementation for |
I'd vote for |
Ah yeah I remember these. Well, probably reason enough not to do extra work here then :) |
I have already tried that.
done. |
For right now, I'll just make a duplicate pull to see the tests and be able to iterate on them if they are incorrect. duplicate pr does not start the workflow either |
I fetched your branch and pushed it to plotly.js repository at the |
I fetched your changes. New tests are running at https://app.circleci.com/pipelines/github/plotly/plotly.js/6866/workflows/19306635-afcf-4f3e-a3a1-ca85f0b75fc0. |
With the changes Also if you fetch |
Ah okay sweet. |
@archmoj I'm not sure how to fix the following error: https://app.circleci.com/pipelines/github/plotly/plotly.js/6866/workflows/7690f800-a50d-4321-97bb-1e19d7814ec8/jobs/156536/parallel-runs/6?filterBy=FAILED&invite=true#step-104-1026
Also if you could tell me how to run just a specific test locally that would be great! |
fix geometricMean computation
Add geomean function, closes #6152!