Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cartesian hover toggle #5879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Sizurka
Copy link

@Sizurka Sizurka commented Aug 5, 2021

The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.

The hover toggle button couldn't be enabled on cartesian plots because
the later setup completely overwrote the initial allowed groups.  So
just make it add the cartesian buttons instead of replacing the groups
completely.
@archmoj
Copy link
Contributor

archmoj commented Mar 23, 2022

@Sizurka Thanks very much for the PR.
Could you please provide a minimal example of illustrating the bug e.g. by forking this codepen?

@Sizurka
Copy link
Author

Sizurka commented May 3, 2022

See here. Note that there is no hover toggle button on the mode bar, despite it being enabled in the layout. Other buttons (e.x. "togglespikelines") work correctly.

@archmoj
Copy link
Contributor

archmoj commented May 6, 2022

Looking good to me.

Please add a test somewhere here:

describe('creates a custom button', function() {

Also I appreciate if you draft 5879_fix.md as described here:
https://github.com/plotly/plotly.js/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants