Moved delete only if it exists (#4883)

Co-authored-by: Steven Yau <[email protected]>
playcanvas · Nov 23, 2022 · 2bab034 · 2bab034
1 parent d72a749
commit 2bab034
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/framework/input/element-input.js b/src/framework/input/element-input.js
@@ -745,9 +745,10 @@ class ElementInput {
  const lastTouchUp = this._clickedEntities[guid] || 0;
  const dt = Date.now() - lastTouchUp;
  fireClick = dt > 300;
+
+ // We do not check another time, so the worst thing that can happen is one ignored click in 300ms.
+ delete this._clickedEntities[guid];
  }
- // We do not check another time, so the worst thing that can happen is one ignored click in 300ms.
- delete this._clickedEntities[guid];
  if (fireClick) {
  this._fireEvent('click', new ElementMouseEvent(event, this._hoveredElement, camera, targetX, targetY, this._lastX, this._lastY));
  }