-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Use jsonurl, update filtering #4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I think the filters behaviour in general can be consolidated and encapsulated a bit more on the frontend to make them easier to work with. The props filter is always a snowflake that makes everything else harder.
EDIT: To be clear I think improving the filters code in general should be done in a follow-up. For now the goal is to get the new stuff functional.
I ran some manual tests myself and haven't found any bugs. We can do some more manual testing on staging next.
Follow-up to #4117 Special goals (e.g. 404, Outbound link click) always reported (none) as results due to a function returning the wrong value.
Follow-up to #4117 Opening a utm modal crashed if there was an existing page filter. Bug struck in during a refactoring.
Follow-up to #4117 Special goals (e.g. 404, Outbound link click) always reported (none) as results due to a function returning the wrong value.
Follow-up to #4117 Opening a utm modal crashed if there was an existing page filter. Bug struck in during a refactoring.
Changes
This PR refactors significant parts of the dashboard react code.
Changes include:
Note that the FE now supports multiple filters, though the request sent to the backend does not, yet.
Testing
I've extensively tested the changes locally, but also planning on recruiting Marco to test out these changes on staging.