Export and import custom events via CSV #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
support-custom-events-in-csv-exports-and-imports
branch
from
3868d0c
to
6d20385
Compare
zoldar
added
the
deploy-to-staging
zoldar
force-pushed
the
support-custom-events-in-csv-exports-and-imports
branch
5 times, most recently
from
fbb0419
to
982d616
Compare
zoldar
force-pushed
the
support-custom-events-in-csv-exports-and-imports
branch
from
621b5ee
to
9a474a5
Compare
RobertJoonas
approved these changes
May 14, 2024
test/plausible_web/controllers/api/external_stats_controller/breakdown_test.exs
Show resolved
Hide resolved
ruslandoga
reviewed
May 17, 2024
| "with_imported" => true | ||
| } | ||
| end | ||
|
|
||
| breakdown = fn params_or_site, by -> | ||
| breakdown = fn params_or_site, by, opts -> |
There was a problem hiding this comment.
props/goals can have a separate specialised function
| # page breakdown's visit_duration difference is within 1% | ||
| assert summary(field(exported_pages, "visit_duration")) == [0, 0, 25, 217.5, 743] | ||
| assert summary(field(imported_pages, "visit_duration")) == [0, 0, 25, 217.55, 742.8] | ||
| # NOTE: page breakdown's visitors difference is up to almost 43% |
There was a problem hiding this comment.
i think it's visit duration
|
|
||
| pairwise(exported_cities, imported_cities, fn exported, imported -> | ||
| assert exported["city"] == imported["city"] | ||
| assert exported["bounce_rate"] == imported["bounce_rate"] | ||
| assert_in_delta exported["bounce_rate"], imported["bounce_rate"], 4 |
There was a problem hiding this comment.
if delta is high, it might be better to be tested separately
| assert exported["pageviews"] == imported["pageviews"] | ||
| assert_in_delta exported["visit_duration"], imported["visit_duration"], 1 | ||
| assert_in_delta exported["visit_duration"], imported["visit_duration"], 2 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements support for importing and exporting custom events via CSVs.
Also, the raw CH dump fixture got replaced with a sample from a smaller site but with more varied set of goal types (including goals with url and path properties). The dump contains complete set of entries from the declared time range - no additional sampling is applied.
Tests
Changelog
Documentation