-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor internal Query schema and introduce WhereBuilder #4082
Merged
Merged
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
e10a06c
New struct format for query after parsing
macobo 1e4473a
WIP refactoring
macobo e59e23d
WIP: Validations working
macobo 149d462
WIP: tuple to list
macobo 8087db8
continued refactoring
macobo 01c445a
WIP: parsing defaults
macobo 361e6bb
Breakdown tests pass
macobo 963a6f2
Window functions fix
macobo 50ce8c0
Fix default
macobo 28da292
Remove dead argument
macobo b77e8c8
Update filters tests
macobo 9639da4
Update query_test.exs
macobo bd0a78e
Fix table_decider
macobo 1662f6b
sources tests pass
macobo 652be42
Filter suggestions fix
macobo 36d7950
revenue/goal filter applied refactor
macobo 9d07c03
Update top_stats matching
macobo 8ab955c
Get stats_controller tests passing
macobo 4d5b2c9
Update neighbor_aggregate_time_on_page
macobo 2c23c7b
Refactor Query.remove_event_filters into Query.remove_filters, add ne…
macobo 3f3118f
Move goal where clause building to new WhereBuilder module
macobo 6c1609a
Move event:name filters
macobo 0f0adce
Move more filters to WhereBuilder
macobo 158c578
Update fragment to allow non-static meta columns
macobo e60ed57
Build where clause for events table using WhereBuilder
macobo f6b98c7
Build sessions table where clause using WhereBuilder
macobo effcaaa
Move time range filtering and site checking to WhereBuilder
macobo 825ca94
WhereBuilder.build_condition method
macobo 3a5aa2b
Remove TODO
macobo bcc4727
_rest pattern for TableDecider, Query pattern matching
macobo c4b1301
Hacky fix to get tests passing for Google API tests
macobo a6cf54e
Typespec fix
macobo ad0e99a
Merge conflict
macobo d7f64d6
refactor special goal filter logic in imported.ex
RobertJoonas c2c2704
Merge remote-tracking branch 'origin/master' into api-new-query-schema
macobo c6a114a
Docs feedback
macobo 47788a5
put_filter
macobo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is already broken, @ukutaht is working on a proper replacement under #4077