Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reboot system after config #3916

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

reboot system after config #3916

wants to merge 1 commit into from

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Mar 20, 2024

Changes

This solves code injection in extra configs, e.g:

my_extra_config.exs

import Config

defmodule Plausible.Application do
  use Application

  def start(_type, _args) do
    raise "oops"
  end
end

TODOs:

  • is there better way?
  • does it affect any of the existing configuration?

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga changed the title reboot_system_after_config reboot system after config Mar 20, 2024
@ruslandoga ruslandoga added the self-hosting Anything self-hosted label Mar 20, 2024
@cnkk cnkk added preview and removed preview labels May 14, 2024
@cnkk cnkk removed the preview label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-hosting Anything self-hosted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants