Redact search params and fragment from referrer #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the referrer URL, the search parameters (following the `?`) and the fragment (following the `#`) might contain personal/sensitive information. They are already dropped by Plausible server, but I think we could even make them never leave the user's device. It could be quite frightening for a user observing network requests in their browser's dev tools, to see that sensitive information is sent to Plausible, a third party service they might have never heard of. Observing that the search params and fragment are not being sent would be reassuring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Redact search params and fragment from referrer
In the referrer URL, the search parameters (following the
?) and the fragment (following the#) might contain personal/sensitive information.They are already dropped by Plausible server, but I think we could even make them never leave the user's device.
It could be quite frightening for a user observing network requests in their browser's dev tools, to see that sensitive information is sent to Plausible, a third party service they might have never heard of.
Observing that the search params and fragment are not being sent would be reassuring.
(Even with
strict-origin-when-cross-origin, search parameters and fragment will be present in the referrer if, for instance, a user middle-clicks a link in the page.)Tests
Changelog
Documentation
Dark mode