Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatanoiseTV TREX One Board. #22

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DatanoiseTV
Copy link

Add support for the TREX One DevBoard with 16MB of Flash.

@valeros
Copy link
Member

valeros commented Nov 25, 2021

Hi @DatanoiseTV ! Please read my comments above.

@valeros valeros self-requested a review November 25, 2021 12:47
@DatanoiseTV
Copy link
Author

Hi @DatanoiseTV ! Please read my comments above.

Sorry, I don't see a comment.

@valeros
Copy link
Member

valeros commented Nov 25, 2021

Do you see my review comments here https://github.com/platformio/platform-raspberrypi/pull/22/files ?

@DatanoiseTV
Copy link
Author

Do you see my review comments here https://github.com/platformio/platform-raspberrypi/pull/22/files ?

Unfortunately not for some reason.

]
],
"mcu": "rp2040",
"variant": "TREX_ONE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this board hasn't been added to the official Arduino framework, so you will need to use the original RASPBERRY_PI_PICO variant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, as long as the extra flag is set during build.

"name": "TREX One (RP2040)",
"upload": {
"maximum_ram_size": 270336,
"maximum_size": 16384000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe 16MB is external flash? How will people be able to utilize it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RP2040 has no internal flash. The RP2040 Pico Board had 4MB of external flash and the TREX One has 16MB. With FreeRTOS, TinyUSB, LVGL etc. 16MB can be very practical (think of LittleFS / SPIFFS).

@valeros
Copy link
Member

valeros commented Nov 25, 2021

OK, I requested changes once again. Are they visible now?

Copy link
Author

@DatanoiseTV DatanoiseTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your comments and provided answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants