Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some UM boards info #1315

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

UnexpectedMaker
Copy link
Contributor

Also renamed tinypico to um_tinypico to match all of the UM board naming. These have been named this way in Arduino for a long time now.

@valeros
Copy link
Member

valeros commented Feb 21, 2024

Hi @UnexpectedMaker, thanks for the PR. The name of the manifest file plays an important role as a board ID in project configurations. It means that your simple renaming tinypico.json to um_tinypico.json may break already configured projects. If you insist on renaming, I'd recommend keeping both files tinypico.json an um_tinypico.json, but the name of the board in the tinypico.json file may contain a phrase like Unexpected Maker TinyPICO (deprecated in favor of "um_tinypico"), so that it can be safely removed in a new major release.

@UnexpectedMaker
Copy link
Contributor Author

@valeros Oh, that's a really good point. I'll revert this change later today, and leave it as is.

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. Please provide more details or it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 22, 2024
@valeros valeros added enhancement and removed stale labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants