This repository has been archived by the owner on May 16, 2024. It is now read-only.
Improve the CLI auth logic #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to use client_id, client_secret, fingerprint, note, and note_url fields in the authorization request. See https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization
The `login` method will send a request to potentially reuse an existing authorization when the auth config contains the `reuse` field with the value `true` and the `id` field with the client id. If no authorization is available, a new one will be returned in the `token` callback parameter, otherwise the `token` callback parameter will be empty, and the caller is assumed to know the token.
| client_secret: @options.secret | ||
| fingerprint: @options.fingerprint | ||
| note: @options.note | ||
| note_url: @options.note_url |
There was a problem hiding this comment.
Please add the above 5 properties only if they exist in @options.
|
Just a few comments which need to be addressed. |
|
@ankon Any update on this? |
|
@ankon Could you give an update on this? |
odykyi
suggested changes
May 8, 2017
| body: scopes, | ||
| url: url.parse(authorizationUrl), | ||
| method: authorizationMethod, | ||
| body: JSON.stringify({ |
There was a problem hiding this comment.
pls use json: true instead of JSON.stringify
ex.
body: {
scopes: scopes,
client_id: this.options.id,
client_secret: this.options.secret,
fingerprint: this.options.fingerprint,
note: this.options.note,
note_url: this.options.note_url
},
json: true
| @@ -81,7 +92,7 @@ | |||
| err = _error; | |||
| callback(new Error('Unable to parse body')); | |||
| } | |||
| if (res.statusCode === 201) { | |||
| if ((ref = res.statusCode) === 200 || ref === 201) { | |||
There was a problem hiding this comment.
pls dont assign variable in if statement
its implicit
|
Oops, missed this. :/ I'm no longer using this library, so right now can not do any updates. |
Aboodi19900
approved these changes
Mar 21, 2019
Repository owner
locked and limited conversation to collaborators
Mar 21, 2019
Repository owner
unlocked this conversation
Jun 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes I needed for creating a desktop application using this library:
client_id,client_secret,note,note_url, andfingerprintin the authorization requestThere is still one open issue here: github will return a hashed token and the last 8 characters when reusing a token, but these values are not provided to the callback, so the app cannot actually verify the token. I'll open a separate issue for that, as it might need incompatible changes to the API.