Fallback if createImageBitmap(Blob) is not supported
#9373
+106
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb052a1:
|
|
|
||
| return createImageBitmap(blob).then(() => true, () => false); | ||
| return testImageFormat(avifData); |
There was a problem hiding this comment.
Can't we simply do new Image here instead of blob/createImageBitmap? This PR seems like a lot of work to see if AVIF works. We are not trying to test if blob + createImageBitmap is supported only if the format is supported by the browser.
There was a problem hiding this comment.
We can't use Image, because it isn't available in workers.
bigtimebuddy
added
the
🥶 Low Priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
According to this
createImageBitmap(Blob)is not supported in Safari.canLoadImageBitmap(), which tests ifloadImageBitmap()is supported.Added thetestImageOrVideoFormat(dataURL)helper to test if an image or video format it supported.Pre-Merge Checklist
npm run lint)npm run test)