Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger: Adding Query parameter to route description. #876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bthrall
Copy link

@bthrall bthrall commented Mar 30, 2021

We handled this by using enums to extend the Parameter class, and a function to allow easy adding of query parameters.

We're not 100% sure if the query function should be on the subpath as well, though that should be easily enough removed if necessary.

@kiplingw kiplingw requested a review from oktal March 30, 2021 23:14
@kiplingw
Copy link
Member

Thanks @bthrall. @oktal, if this looks fine to you I'll merge. I'm not really familiar with the integrated Swagger functionality and haven't used it.

@kiplingw kiplingw self-assigned this Mar 30, 2021
@dennisjenkins75
Copy link
Collaborator

I'm concerned that this PR directly modifies rapidjson instead of patching it upstream and then properly integrating that fix here. Are you doing a hard-fork of rapidjson?

@bthrall
Copy link
Author

bthrall commented Mar 31, 2021

I'm concerned that this PR directly modifies rapidjson instead of patching it upstream and then properly integrating that fix here. Are you doing a hard-fork of rapidjson?

It modifies the rapidjson serializer used by Pistache to generate the Swagger JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants