Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Linux and Gnome compatibility #28

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Linux and Gnome compatibility #28

wants to merge 13 commits into from

Conversation

nmaggioni
Copy link

@nmaggioni nmaggioni commented May 2, 2016

  • Environment integration
    • Logfiles path
    • Gnome
      • Notifications
      • Menu applet
  • Sources integration
    • systemd
  • Parsers integration
    • connections N/A without third-party software.
    • ftp Too many software choices available.
    • Ostiarius N/A under Linux.
    • portscan N/A without third-party software.
    • ssh
    • sudo
    • vnc Too many software choices available.

@nmaggioni nmaggioni changed the title Linux compatibility Linux and Gnome compatibility May 2, 2016
@pirate pirate modified the milestone: v3.0 May 2, 2016
@nmaggioni
Copy link
Author

I think I'm quite done with this PR: unfortunately many functions require additional third-party software to work properly (portscan detection, vnc/ftp/generic port connections) and some are just incompatible (Ostiarius).

A menu applet might be a bit useless with this restricted set of functionalities, I think it'd be better to just have a runnable script under Linux.

SERVICE=growler.py
OUTFILE=~/Library/Logs/SecurityGrowler.log
OUTFILE=/tmp/SecurityGrowler.log
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about /var/log/SecurityGrowler.log ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On most distros writing to /var/log would require root permission, or some other unprivileged-fork voodoo as far as I know.
Another viable alternative could be ~/.logs, but that's not really a standard too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about .local/share/SecurityGrowler? most distros with a DE have support for .local

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like logging in there, I have the suspicion that it would just clutter the space.

AFAIK logging to /{.local,usr}/share is not a common practice, but I may just be not informed enough.

@pirate
Copy link
Owner

pirate commented May 12, 2016

I love it! I'm about ready to merge it after some tiny changes. Maybe for v3.5 I'll think about splitting the mac and linux shell scripts entirely. We could call one linux.sh and the other mac.sh, and have the Platypus app only load mac.sh, that way it's super clear to the user which one they need to be running.

A couple quick questions, what version(s) of Linux are you testing this on? And did you manage to test the Platypus app on a mac again with all these changes? If not no worries, I'll check out the branch and recompile the Platypus app to make sure everything still works.

Thanks for all the hard work, this looks awesome and I'm excited that SC will have Linux support soon!

Automatic OS detection
@nmaggioni
Copy link
Author

I'm testing this on Manjaro, an Arch Linux derivative.

Unfortunately I didn't manage to get my hands on an OS X machine, so I can't really speak out for that OS... But I've been careful to avoid tweaking core functionalities of SG too much, so my best guess is that everything should work as fine as before - given that

from sys import platform as _platform

is the only single point of failure. If on OS X that gives "Darwin" as the docs say, the script shouldn't implode.

@nmaggioni
Copy link
Author

Synced and ready to merge 👍

@Fred-Barclay
Copy link

@pirate Any update on this? I'd love to see this on Linux. 😄

@pirate
Copy link
Owner

pirate commented Apr 11, 2017

As it stands if I just merge this branch it'll break OS X support in a couple places. I've checked out the branch and I'm debugging it now, there are a couple things left and and a few behavior tweaks I want to make too. I'll keep you guys posted, sorry for the long delay in getting to this!

@nmaggioni
Copy link
Author

No worries at all, let me know if I can do something.

@Fred-Barclay
Copy link

@pirate Since growler is temporarily on hold, would you mind me forking it and developing it with more of an eye to the Linux features? I don't have a Mac so I wouldn't be able to maintain the macOS portions (I might end up removing the macOS specific stuff unless someone else could handle that part).

@pirate
Copy link
Owner

pirate commented Dec 31, 2017

@Fred-Barclay go for it, although I think my original architecture is a bit flawed and could be improved. It could be better designed with a more robust event loop and ability to handle sources of different types in a clean manner.

You're welcome to copy the code or just copy the ideas and rewrite it from scratch on Linux, whatever is easiest. Also take a look at https://github.com/benjojo/PushAlotAuth

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants