-
Notifications
You must be signed in to change notification settings - Fork 57
Linux and Gnome compatibility #28
base: master
Are you sure you want to change the base?
Conversation
Source will be ready as soon as it's connected to the journal
Not available under Linux
Plus miscellaneous regex variations
Some systems use Python 3 as default alias for `python`
I think I'm quite done with this PR: unfortunately many functions require additional third-party software to work properly (portscan detection, vnc/ftp/generic port connections) and some are just incompatible (Ostiarius). A menu applet might be a bit useless with this restricted set of functionalities, I think it'd be better to just have a runnable script under Linux. |
SERVICE=growler.py | ||
OUTFILE=~/Library/Logs/SecurityGrowler.log | ||
OUTFILE=/tmp/SecurityGrowler.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about /var/log/SecurityGrowler.log
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On most distros writing to /var/log
would require root permission, or some other unprivileged-fork voodoo as far as I know.
Another viable alternative could be ~/.logs
, but that's not really a standard too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about .local/share/SecurityGrowler
? most distros with a DE have support for .local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel like logging in there, I have the suspicion that it would just clutter the space.
AFAIK logging to /{.local,usr}/share
is not a common practice, but I may just be not informed enough.
I love it! I'm about ready to merge it after some tiny changes. Maybe for v3.5 I'll think about splitting the mac and linux shell scripts entirely. We could call one A couple quick questions, what version(s) of Linux are you testing this on? And did you manage to test the Platypus app on a mac again with all these changes? If not no worries, I'll check out the branch and recompile the Platypus app to make sure everything still works. Thanks for all the hard work, this looks awesome and I'm excited that SC will have Linux support soon! |
Automatic OS detection
I'm testing this on Manjaro, an Arch Linux derivative. Unfortunately I didn't manage to get my hands on an OS X machine, so I can't really speak out for that OS... But I've been careful to avoid tweaking core functionalities of SG too much, so my best guess is that everything should work as fine as before - given that from sys import platform as _platform is the only single point of failure. If on OS X that gives |
Synced and ready to merge 👍 |
@pirate Any update on this? I'd love to see this on Linux. 😄 |
As it stands if I just merge this branch it'll break OS X support in a couple places. I've checked out the branch and I'm debugging it now, there are a couple things left and and a few behavior tweaks I want to make too. I'll keep you guys posted, sorry for the long delay in getting to this! |
No worries at all, let me know if I can do something. |
@pirate Since growler is temporarily on hold, would you mind me forking it and developing it with more of an eye to the Linux features? I don't have a Mac so I wouldn't be able to maintain the macOS portions (I might end up removing the macOS specific stuff unless someone else could handle that part). |
@Fred-Barclay go for it, although I think my original architecture is a bit flawed and could be improved. It could be better designed with a more robust event loop and ability to handle sources of different types in a clean manner. You're welcome to copy the code or just copy the ideas and rewrite it from scratch on Linux, whatever is easiest. Also take a look at https://github.com/benjojo/PushAlotAuth |
Menu appletN/A without third-party software.connections
Too many software choices available.ftp
N/A under Linux.Ostiarius
N/A without third-party software.portscan
ssh
sudo
Too many software choices available.vnc