Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code base to box2d 2.4.1 #232

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

update code base to box2d 2.4.1 #232

wants to merge 8 commits into from

Conversation

zOadT
Copy link
Collaborator

@zOadT zOadT commented Mar 5, 2023 •
edited

Let's see if we can update to 2.4.1 in a reasonable time. There are some breaking changes so I want to get them into 1.0.

Current state

  • Planck is originally based on box2d's commit: 86c0b07e7caed97ee14c019c65efb622ff1e836b
  • With Update Codebase to box2d may 2017 #246 the codebase got updated to 8cbddc3328ea648c998427fccee7715ab409548c
  • With feat: add ShapeCast function #247 the codebase got further updated to d9840ac3ea475ede539fa98d9a7a41e5f2c546a7 (+ commit a22ddee186844dd61612523259cf2fc288d03b03)
  • The main branch is currently on commit: d9840ac3ea475ede539fa98d9a7a41e5f2c546a7 (+ commit a22ddee186844dd61612523259cf2fc288d03b03)

Notes:

4447920c8e160a4c207929b21010d76922c910af: Skipped

Breaking Changes:

  • body.set/isActive got renamed to body.set/isEnabled

ShapeCast:

Rope

  • Changes to b2Rope.cpp and b2Rope.h are ignored, because they are not implemented anyway yet.
    • This includes
      • 5ae818e95ddd09622bad4fd295311ca4706ad2b2
      • 37e2dc25f8da158abda10324d75cb4d1db009adf
      • 3632516f02c9b71fa81e0ef6663d1390f172b598
      • ebb7c5e24ab289c394dffe5d56e3a4025c72c0fc
      • fda3f0c5b8dfcd068e2c3c6cfb99204d042b7522

TODOs:

  • fb732737f179cf0497488ead020de666e468c55f: Check Contact.solveVelocityConstraint and Solver.solveIsland as they seem to be implemented differently
  • b6a97c6980410bdc41d48084420f3a2bd9497321: is Box2D/Testbed/Tests/chainProblem.h needed?
  • 17093ba37897f268aa2b48f3c25d0c96e275a702: is Box2D/Testbed/Tests/Skier.h needed?

@zOadT zOadT marked this pull request as draft March 5, 2023 14:14
@zOadT zOadT changed the title Draft: update code base to box2d 2.4.1 update code base to box2d 2.4.1 Mar 5, 2023
@zOadT zOadT force-pushed the box2d-2.4 branch 2 times, most recently from f0ac22c to 1346c58 Compare August 3, 2023 18:17
@zOadT zOadT mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakiba shakiba shakiba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zOadT @shakiba