Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11021] Apply JsonFields #11027

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 16, 2024

No description provided.

@emeroad emeroad added this to the 3.0.0 milestone May 16, 2024
@emeroad emeroad linked an issue May 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.70423% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 37.08%. Comparing base (ed7aba4) to head (5ca7a22).

Current head 5ca7a22 differs from pull request most recent head 23dac92

Please upload reports for the commit 23dac92 to get more accurate results.

Files Patch % Lines
...p/pinpoint/common/server/util/json/JsonFields.java 45.71% 19 Missing ⚠️
...point/web/view/NodeHistogramSummarySerializer.java 0.00% 7 Missing ⚠️
...om/navercorp/pinpoint/web/view/NodeSerializer.java 0.00% 7 Missing ⚠️
...nt/web/view/ApplicationTimeHistogramViewModel.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11027      +/-   ##
============================================
- Coverage     37.11%   37.08%   -0.03%     
+ Complexity    11973    11964       -9     
============================================
  Files          3930     3926       -4     
  Lines         96884    96883       -1     
  Branches      10380    10381       +1     
============================================
- Hits          35955    35930      -25     
- Misses        57975    57997      +22     
- Partials       2954     2956       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad force-pushed the #11021_jsonfields branch 2 times, most recently from 5ca7a22 to 92f7b0b Compare May 17, 2024 08:36
@emeroad emeroad merged commit 7ba565b into pinpoint-apm:master May 17, 2024
1 check passed
@emeroad emeroad deleted the #11021_jsonfields branch May 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JsonFields for dynamic json field names
1 participant