Modify to read RootConfig file of js ext #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
microsoft/TypeScript#30400 (comment) It allows to support configure with statements, we have to approach it carefully. tsconfig also doesn't allow js config. |
|
@feelform One of the limitations of json is that it doesn't support comments. This causes inconvenience. and I think there should be a variety of pinpoint-agent setting methods that suit the user's likes. Even if the js configuration file has state, it is the user's responsibility. Are there any other problems expected when the configure has a state? |
- `import 'pinpoint-node-agent'` 방식은 한줄로 노드 에이전트를 띄울 수 있지만, 환경 변수나 외부의 config.json 파일 외에 에이전트 객체의 설정 값을 바꿀 수 있는 방법이 없다. - 그래서 wrapper function 으로 한번 감싸주고 외부로 부터 인자를 주입 받아 필요시 동적으로 pinpointNodeAgent 를 생성할 수 있도록 변경했다. - 하위 호환 때문에 PR은 올리지 못할 덧... - TypeScript 환경에서 쓸거라 d.ts 파일을 추가함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are people who want to manage config files such as tsconfig,
pm2,webpack,eslint, etc. as*.jsrather than*.jsonfiles. And most packages support reading configuration files with the*.jsextension.I want to manage the pinpoint-config file with js extension rather than json extension.
This is a PR on the above.