Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sqlgram links #17468

Merged
merged 31 commits into from
May 27, 2024
Merged

Replace sqlgram links #17468

merged 31 commits into from
May 27, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 10, 2024

What is changed, added or deleted? (Required)

Closes #17467

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@dveeden dveeden requested review from Icemap and kennytm May 14, 2024 07:26
@qiancai qiancai self-assigned this May 17, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label May 17, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 17, 2024
@qiancai qiancai added type/enhancement This issue/PR improves documentation usability or supplements document content. missing-translation-status This PR does not have translation status info. and removed missing-translation-status This PR does not have translation status info. labels May 17, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024
@dveeden dveeden requested a review from kennytm May 23, 2024 06:36
qiancai
qiancai approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
develop/dev-guide-create-table.md Outdated Show resolved Hide resolved
develop/dev-guide-tidb-crud-sql.md Outdated Show resolved Hide resolved
develop/dev-guide-tidb-crud-sql.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed May 23, 2024
View reviewed changes
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
kennytm
kennytm approved these changes May 23, 2024
View reviewed changes
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2024

@kennytm: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai requested a review from easonn7 May 24, 2024 02:34
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request May 24, 2024
Preview PR pingcap/docs#17468 and this preview is triggered from commit
1ae38e4 
pingcap/docs@e2abe3e
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request May 24, 2024
Preview PR pingcap/docs#17468 and this preview is triggered from commit
511684d 
pingcap/docs@e2abe3e
@hfxsd hfxsd self-requested a review May 24, 2024 06:56
hfxsd
hfxsd approved these changes May 27, 2024
View reviewed changes
develop/dev-guide-tidb-crud-sql.md Outdated Show resolved Hide resolved
develop/dev-guide-tidb-crud-sql.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-overview.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-23 08:29:28.580598872 +0000 UTC m=+2333122.337734445: ☑️ agreed by qiancai.
  • 2024-05-27 02:47:52.050894022 +0000 UTC m=+2658225.808029592: ☑️ agreed by hfxsd.

dveeden and others added 2 commits May 27, 2024 06:28
@dveeden @hfxsd
Update develop/dev-guide-tidb-crud-sql.md
87bd887 
Co-authored-by: xixirangrang <[email protected]>
@dveeden @hfxsd @qiancai
Apply suggestions from code review
eb5cf34 
Co-authored-by: xixirangrang <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
@qiancai
Copy link
Collaborator

qiancai commented May 27, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9401288 into pingcap:master May 27, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

@Oreoxmt Oreoxmt Awaiting requested review from Oreoxmt

@Icemap Icemap Awaiting requested review from Icemap

@easonn7 easonn7 Awaiting requested review from easonn7

Assignees

@qiancai qiancai

Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace links to https://pingcap.github.io/sqlgram/
5 participants
@dveeden @qiancai @kennytm @hfxsd @Frank945946