Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing left-side active border overflow on input box #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing left-side active border overflow on input box #4

wants to merge 1 commit into from

Conversation

engageintellect
Copy link
Contributor

Problem

input highlight overflowing on left side:
highlight-overflow

Solution

replace redundant margin with a little padding... This also equates to a little more screen real estate on mobile layouts
after-hightlight

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@engageintellect
Update index.tsx
b9dfc65 
- fixed overflowing border highlight on left side of input
- reducing redundant margin
- adding a little more usable screen real estate on mobile
@engageintellect engageintellect changed the title Update index.tsx Fixing left-side active border overflow on input box Jul 25, 2023
@HarounAns
Copy link

HarounAns commented Sep 24, 2023 •
edited

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarounAns HarounAns HarounAns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@engageintellect @HarounAns